[PATCH] D124106: [lld/mac] Warn that writing zippered outputs isn't implemented

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: lld/MachO/Driver.cpp:641-651
+  if (platformVersions.size() > 2) {
+    error("must specify -platform_version at most twice");
+    return PLATFORM_UNKNOWN;
+  }
+  if (platformVersions.size() > 1) {
+    // FIXME: If you implement support for this, add a diagnostic if
+    // outputType is not dylib or bundle -- linkers shouldn't be able to
----------------
cover these with a test?


================
Comment at: lld/MachO/Driver.cpp:645
+  }
+  if (platformVersions.size() > 1) {
+    // FIXME: If you implement support for this, add a diagnostic if
----------------
nit: seems more direct this way


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124106/new/

https://reviews.llvm.org/D124106