[PATCH] D123988: [LoongArch] Add basic floating-point instructions definition
Renato Golin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 21 01:00:53 PDT 2022
rengolin added a comment.
In D123988#3463790 <https://reviews.llvm.org/D123988#3463790>, @MaskRay wrote:
> https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted says "If it is likely that others will want to review a recently-posted patch, especially if there might be objections, but no one else has done so yet, it is also polite to provide a qualified approval (e.g., “LGTM, but please wait for a couple of days in case others wish to review”). If approval is received very quickly, a patch author may also elect to wait before committing (and this is certainly considered polite for non-trivial patches). Especially given the global nature of our community, this waiting time should be at least 24 hours. Please also be mindful of weekends and major holidays."
Apologies, my approval had that connotation but I forgot to write the exact wording.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123988/new/
https://reviews.llvm.org/D123988
More information about the llvm-commits
mailing list