[PATCH] D123988: [LoongArch] Add basic floating-point instructions definition

Wed Apr 20 22:24:02 PDT 2022

SixWeining added a comment.

In D123988#3463790 <https://reviews.llvm.org/D123988#3463790>, @MaskRay wrote:

> In D123988#3463755 <https://reviews.llvm.org/D123988#3463755>, @xen0n wrote:
>
>> In D123988#3463734 <https://reviews.llvm.org/D123988#3463734>, @SixWeining wrote:
>>
>>> In D123988#3463732 <https://reviews.llvm.org/D123988#3463732>, @xen0n wrote:
>>>
>>>> Welp I'm 1 hour late, quick hands... we could use some cleanups later though.
>>>
>>> Sorry, I should wait for a while.
>>
>> Not particularly your fault; I've been busy in `$DAY_JOB` so I'm not paying as close attention as maybe 1 month ago. The comment is more-or-less nitpicky though, no harm in actual functionality.
>
> https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted says "If it is likely that others will want to review a recently-posted patch, especially if there might be objections, but no one else has done so yet, it is also polite to provide a qualified approval (e.g., “LGTM, but please wait for a couple of days in case others wish to review”). If approval is received very quickly, a patch author may also elect to wait before committing (and this is certainly considered polite for non-trivial patches). Especially given the global nature of our community, this waiting time should be at least 24 hours. Please also be mindful of weekends and major holidays."
>
> In this case @xen0n is very active on various things of LoongArch and often has opinions on the implementation, so it could be nicer to wait a bit.
> This is perhaps more relevant for new contributors.

Thanks for your reminding. It's OK to me. I will wait a while in future commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123988/new/

https://reviews.llvm.org/D123988