[PATCH] D123985: [ELF] Error on invalid GOT or PLT relocations

Tue Apr 19 22:56:54 PDT 2022

smeenai added a comment.

In D123985#3460991 <https://reviews.llvm.org/D123985#3460991>, @MaskRay wrote:

> I haven't read other patches yet. If the issue only happens due to a bug, I think guarding in `#ifndef NDEBUG` is probably more appropriate and goes in line with `checkDynamicRelocsDefault`.

Yup, this is happening due to a bug which is fixed by the next patch.

By guarding with `#ifndef NDEBUG`, did you mean keeping the current `error` and guarding it, or just switching to an assert? In either case, should I keep the test in this patch? (The next patch which fixes the bug has to get rid of the test anyway, because I couldn't think of another way to trigger this bug.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123985/new/

https://reviews.llvm.org/D123985