[PATCH] D123985: [ELF] Error on invalid GOT or PLT relocations

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 22:49:19 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/SyntheticSections.cpp:1592
 uint32_t DynamicReloc::getSymIndex(SymbolTableBaseSection *symTab) const {
-  if (needsDynSymIndex())
-    return symTab->getSymbolIndex(sym);
+  if (needsDynSymIndex()) {
+    size_t index = symTab->getSymbolIndex(sym);
----------------
```
if (!needsDynSymIndex())
  return 0;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123985/new/

https://reviews.llvm.org/D123985



More information about the llvm-commits mailing list