[PATCH] D123264: [RISCV] Pre-RA expand pseudos pass

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 10:21:25 PDT 2022


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp:439
+  Symbol.setTargetFlags(FlagsHi);
+  MCSymbol *AUIPCSymbol = MF->getContext().createNamedTempSymbol("PCRelHi");
+
----------------
As a quick non-technical comment, if we're going to give names to these symbols, can we please use .Lpcrel_hiN to match what you get from expanding the pseudos in RISCVAsmParser rather than a different spelling of the same thing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123264/new/

https://reviews.llvm.org/D123264



More information about the llvm-commits mailing list