[PATCH] D123964: CodeGen: Replace some uses of LLVMTargetMachine with TargetMachine

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 20:56:32 PDT 2022


echristo added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineModuleInfo.h:127
 public:
-  explicit MachineModuleInfo(const LLVMTargetMachine *TM = nullptr);
+  explicit MachineModuleInfo(const TargetMachine *TM = nullptr);
 
----------------
This (and the below) with a reference are a little disturbing. (I know you didn't change it, but...)


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:137
+  /// registers, except that variadic defs will be allocated vregs.
+  virtual bool usesPhysRegsForValues() const { return true; }
+
----------------
I'm curious what this changes here versus using LLVMTargetMachine. It's been a while since I've looked.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123964/new/

https://reviews.llvm.org/D123964



More information about the llvm-commits mailing list