[PATCH] D123970: [RISCV] Add isCommutable to ADD/ADDW/MUL/AND/OR/XOR.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 17:43:45 PDT 2022

Previous message: [PATCH] D123970: [RISCV] Add isCommutable to ADD/ADDW/MUL/AND/OR/XOR.
Next message: [PATCH] D123970: [RISCV] Add isCommutable to ADD/ADDW/MUL/AND/OR/XOR.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

jrtc27 added a comment.

Might be clearer as `let isCommutable = 1/true in` on each def? There aren't that many of them, so that keeps it self-documenting and avoids long argument lists.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123970/new/

https://reviews.llvm.org/D123970

Previous message: [PATCH] D123970: [RISCV] Add isCommutable to ADD/ADDW/MUL/AND/OR/XOR.
Next message: [PATCH] D123970: [RISCV] Add isCommutable to ADD/ADDW/MUL/AND/OR/XOR.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list