[PATCH] D123814: [compiler-rt][lsan] Update CanBeAHeapPointer for AArch64
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 18 14:33:23 PDT 2022
MaskRay added inline comments.
================
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:244
+static inline bool CouldBeUserPointer(uptr p) {
// Since our heap is located in mmap-ed memory, we can assume a sensible lower
// bound on heap addresses.
----------------
The s/Can/Could/ change seems unnecessary?
If you want to change it, in other places of LLVM, MayBe is more common.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123814/new/
https://reviews.llvm.org/D123814
More information about the llvm-commits
mailing list