[PATCH] D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 10:36:37 PDT 2022


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM

I think that debug info handling might be a good argument for splitting the similarity identifier into a similarity finding version + outlining version. The outliner needs to be considerate about what it does to debug info, but the similarity identifier doesn't. Someone very well may want to ask questions about debug info similarity in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123903/new/

https://reviews.llvm.org/D123903



More information about the llvm-commits mailing list