[PATCH] D123903: [IRSim] Ignore Debug instructions with constructing canonical numbering for basic blocks

[Andrew Litteken via Phabricator via llvm-commits]

AndrewLitteken added a comment.

> I don't know that much about this analysis pass to say if it is correct to skip dbg intrinsics like this. (And should for example lifetime instrinsics be skipped in the same way?)

Lifetime intrinsics are currently excluded from being matched for similarity, but that's mostly because it causes problems for the outliner.  Debug instructions are allowed to be in an outlined region, but are not used in the similarity matching itself.  This is mostly because the IRSimilarityIdentifier was built for the outliner, but there has been some discussion about separating the two further and building a specific Identifier for the outliner itself and then one for general similarity.  This is (yet another) piece that might push that decision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123903/new/

https://reviews.llvm.org/D123903