[PATCH] D123897: [X86] Unbreak LIT/FileCheck

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 09:44:39 PDT 2022


lebedev.ri added a comment.

In D123897#3456947 <https://reviews.llvm.org/D123897#3456947>, @tstellar wrote:

> I will try to be more specific:
>
> Paragraph 1:
>
> - This contains a non-technical criticism of someone else's work and provides no useful information about the commit.  Please remove.
>
> Paragraph 2:
>
> - LGTM
>
> Paragraph 3:
>
> - I don't understand exactly what is being said here, but the words 'destroyed' and 'damaging' seem overly aggressive. Please drop this paragraph too.  The 2nd paragraph on its own is a good enough commit message.

Apologies, it seems like the feedback here arrives much faster than usual, so there are merge conflicts.
If the current description is still seen as bad, here's a black marker <https://reviews.llvm.org/differential/revision/edit/123897/>, feel free to fine-tune it.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897



More information about the llvm-commits mailing list