[PATCH] D123897: [X86] Unbreak LIT/FileCheck
Tom Stellard via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 18 09:22:39 PDT 2022
tstellar requested changes to this revision.
tstellar added a comment.
This revision now requires changes to proceed.
I will try to be more specific:
Paragraph 1:
- This contains a non-technical criticism of someone else's work and provides no useful information about the commit. Please remove.
Paragraph 2:
- LGTM
Paragraph 3:
- I don't understand exactly what is being said here, but the words 'destroyed' and 'damaging' seem overly aggressive. Please drop this paragraph too. The 2nd paragraph on its own is a good enough commit message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123897/new/
https://reviews.llvm.org/D123897
More information about the llvm-commits
mailing list