[PATCH] D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64.

[Esme Yi via Phabricator via llvm-commits]

Esme updated this revision to Diff 423334.
Esme added a comment.

Hi @DiggerLin, Sorry for the late update, I have verified that the `SignAndSize` value should be 15 for both `fixup_ppc_half16ds` and `fixup_ppc_half16dq`. Although there are zeros being implied, the totally size should be a 16-bit fixup. I confirmed this by testing LIT and test-suite, and the test-suite passes only if the value is 15, otherwise there will be an error like this

  Relocation overflow in reference to: L..CPI168_7 (entry 3199)
          Address: 0x00082c12; RLD type: R_TOC; RLD length: 14


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122287/new/

https://reviews.llvm.org/D122287

Files:
  llvm/lib/MC/XCOFFObjectWriter.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFObjectWriter.cpp
  llvm/test/CodeGen/PowerPC/aix-available-externally-linkage.ll
  llvm/test/CodeGen/PowerPC/aix-extern-weak.ll
  llvm/test/CodeGen/PowerPC/aix-extern.ll
  llvm/test/CodeGen/PowerPC/aix-func-align.ll
  llvm/test/CodeGen/PowerPC/aix-internal.ll
  llvm/test/CodeGen/PowerPC/aix-llvm-intrinsic.ll
  llvm/test/CodeGen/PowerPC/aix-return55.ll
  llvm/test/CodeGen/PowerPC/aix-weak.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-data-only-notoc.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-externL.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-huge-relocs.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-lcomm.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-lower-comm.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-reloc.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-rodata.ll
  llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll
  llvm/test/CodeGen/PowerPC/basic-toc-data-def.ll
  llvm/test/CodeGen/PowerPC/basic-toc-data-extern.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122287.423334.patch
Type: text/x-patch
Size: 149601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220418/5b824c05/attachment-0001.bin>