[PATCH] D123798: [llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all

John McIver via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 17 20:28:51 PDT 2022


jmciver added a comment.

@MaskRay Thank you for your feedback! I have implemented the following changes:

- Comment has been added to `ELF/only-keep-debug.test` explaining that `--only-keep-debug` overrides `--strip-all`
- Differential title has been updated to be more imperative

Sorry about the extra revision diffs (still learning `arc`), squashing commits worked.

Once this is re-approved can someone please commit on my behalf:
Name: `John McIver`
Email: `john.mciver.iii at gmail.com`

Thanks again @MaskRay for taking the time to review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123798/new/

https://reviews.llvm.org/D123798



More information about the llvm-commits mailing list