[PATCH] D123798: [llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

[John McIver via Phabricator via llvm-commits]

jmciver updated this revision to Diff 423323.
jmciver added a comment.

Updating D123798 <https://reviews.llvm.org/D123798>: [llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

Add comment to ELF/only-keep-debug.test explaining default option override. This
change is per feedback provided during the patch review process.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123798/new/

https://reviews.llvm.org/D123798

Files:
  llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test


Index: llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test
===================================================================
--- llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test
+++ llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test
@@ -1,7 +1,7 @@
 # RUN: yaml2obj --docnum=1 %s -o %t1
 # RUN: llvm-objcopy --only-keep-debug %t1 %t1.dbg
 # RUN: llvm-readelf -S -l -x .note1 -x .note2 -x .debug_abbrev -x .debug_frame -x .debug_info %t1.dbg | FileCheck %s
-
+## --only-keep-debug suppresses the default --strip-all
 # RUN: llvm-strip --only-keep-debug %t1
 # RUN: llvm-readelf -S -l -x .note1 -x .note2 -x .debug_abbrev -x .debug_frame -x .debug_info %t1 | FileCheck %s
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123798.423323.patch
Type: text/x-patch
Size: 684 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220418/83e383ac/attachment.bin>