[PATCH] D123798: [llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 17 10:15:46 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

> [llvm-objcopy] llvm-strip option --only-keep-debug should suppress default --strip-all

An imperative sentence is more common as the subject line.
`option` in `option --only-keep-debug` does not convey extra information.
You may use `[llvm-objcopy] Make llvm-strip --only-keep-debug suppress default --strip-all`



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/only-keep-debug.test:5
 
+# RUN: llvm-strip --only-keep-debug %t1
+# RUN: llvm-readelf -S -l -x .note1 -x .note2 -x .debug_abbrev -x .debug_frame -x .debug_info %t1 | FileCheck %s
----------------
Add a comment `## --only-keep-debug suppresses the default --strip-all.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123798/new/

https://reviews.llvm.org/D123798



More information about the llvm-commits mailing list