[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/tools/dxil-dis/CMakeLists.txt:28
+set(BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/DXC-bins)
+set(GIT_SETTINGS GIT_REPOSITORY https://github.com/microsoft/DirectXShaderCompiler.git)
+
----------------
thakis wrote:
> Adding a dep to another github repo is pretty unusual, even though it's off by default. Was this part explicitly discussed somewhere?
Not explicitly. The dependency is optional and only for testing. It builds a copy of the modified llvm-3.7 llvm-dis tool to verify that the newly emitted Bitcode can be read.

Each part of this is configurable. It can clone and build, or build from a local directory, or just take a prebuilt tool.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082