[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/tools/dxil-dis/CMakeLists.txt:28
+set(BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/DXC-bins)
+set(GIT_SETTINGS GIT_REPOSITORY https://github.com/microsoft/DirectXShaderCompiler.git)
+
----------------
Adding a dep to another github repo is pretty unusual, even though it's off by default. Was this part explicitly discussed somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082