[PATCH] D123764: [llvm-objdump] Implemented PrintBranchImmAsAddress for MIPS

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 16:01:47 PDT 2022


sdardis added inline comments.


================
Comment at: llvm/lib/Target/Mips/MicroMipsInstrInfo.td:1326
   def : MipsInstAlias<"wait", (WAIT_MM 0x0), 1>, ISA_MICROMIPS;
+  def : MipsInstAlias<"nop", (SLL ZERO, ZERO, 0), 1>, ISA_MICROMIPS;
   def : MipsInstAlias<"nop", (SLL_MM ZERO, ZERO, 0), 1>, ISA_MICROMIPS;
----------------
This line is incorrect or a spurious change. Placing this alias here would  (attempt to) produce a MIPS standard encoded instruction of `sll` rather than a microMIPS encoded instruction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123764/new/

https://reviews.llvm.org/D123764



More information about the llvm-commits mailing list