[PATCH] D123554: GlobalISel: Add LLT helper to multiply vector sizes

[Jessica Paquette via Phabricator via llvm-commits]

paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Support/LowLevelTypeImpl.h:213
+  /// \p Factor elements.
+  LLT multiplyElements(int Factor) const {
+    if (isVector()) {
----------------
arsenm wrote:
> paquette wrote:
> > why int?
> Copy paste from the above divide. Plus I'm  generally of the belief that using unsigned is bad, but basically everywhere else uses unsigned
that's like the opposite of my personal belief


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123554/new/

https://reviews.llvm.org/D123554