[PATCH] D123554: GlobalISel: Add LLT helper to multiply vector sizes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 15 13:38:12 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/include/llvm/Support/LowLevelTypeImpl.h:213
+  /// \p Factor elements.
+  LLT multiplyElements(int Factor) const {
+    if (isVector()) {
----------------
paquette wrote:
> why int?
Copy paste from the above divide. Plus I'm  generally of the belief that using unsigned is bad, but basically everywhere else uses unsigned


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123554/new/

https://reviews.llvm.org/D123554



More information about the llvm-commits mailing list