[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

Removing me as a blocker here, I think the opaque pointers concern is sufficiently addressed by dependent patches. I haven't looked carefully over the code here, on the assumption that this is just boring "copy of bitcode writing with necessary tweaks for DXIL".



================
Comment at: llvm/test/tools/dxil-dis/FMA.ll:6
+
+; CHECK: Function Attrs: nounwind readnone
+; Function Attrs: norecurse nounwind readnone willreturn
----------------
pete wrote:
> Looks like this is actually testing function attributes, not fma. Can you change the test name, or add the check line for an fma if that is the intention?
Comment not resolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082