[PATCH] D122082: Add DXIL Bitcode Writer and DXIL testing

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/tools/dxil-dis/CMakeLists.txt:39
+
+if (CMAKE_HOST_UNIX)
+  set(LLVM_LINK_OR_COPY create_symlink)
----------------
MaskRay wrote:
> Any reason cmake/modules/AddLLVM.cmake `add_llvm_tool_symlink` can't be used?
Sorry @MaskRay, I should have acknowledged this comment earlier. `add_llvm_tool_symlink` uses generator expressions to read values from the underlying target that doesn't work with this terrible external project goop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122082/new/

https://reviews.llvm.org/D122082