[PATCH] D123628: [InstCombine] Bail on memrchr calls with an excessive size.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 09:23:38 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:906
+
   return nullptr;
 }
----------------
xbolva00 wrote:
> But currently this patch does not make sense a bit as we would reach this nullptr (with your patch we reach it sooner).
> 
> So in the current form, I dont think we need this patch. This “bail out” you can add in the patch which uses this patch as a base.
Yeah, this makes more sense as part of the next patch in the stack now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123628/new/

https://reviews.llvm.org/D123628



More information about the llvm-commits mailing list