[PATCH] D123628: [InstCombine] Bail on memrchr calls with an excessive size.

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 13:44:06 PDT 2022


xbolva00 added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:906
+
   return nullptr;
 }
----------------
But currently this patch does not make sense a bit as we would reach this nullptr (with your patch we reach it sooner).

So in the current form, I dont think we need this patch. This “bail out” you can add in the patch which uses this patch as a base.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123628/new/

https://reviews.llvm.org/D123628



More information about the llvm-commits mailing list