[PATCH] D123449: [AArch64][SelectionDAG] Refactor to support more scalable vector extending stores

[Allen zhong via Phabricator via llvm-commits]

Allen marked 2 inline comments as done.
Allen added a comment.

ping?

________________________________

钟云德 Zhong Yunde
Mobile: +86-50000036116(For Welink,eSpace Calls)
Email: zhongyunde at huawei.com

发件人：Paul Walker via Phabricator <reviews at reviews.llvm.org>
收件人：Zhongyunde <zhongyunde at huawei.com>;paul.walker <paul.walker at arm.com>;david.sherwood <david.sherwood at arm.com>;efriedma <efriedma at quicinc.com>
抄 送：alextsao1999 <alextsao1999 at outlook.com>;llvm-commits <llvm-commits at lists.llvm.org>;kristof.beyls <kristof.beyls at arm.com>;ecnelises <ecnelises at outlook.com>;acmerzhangxipeng <acmerzhangxipeng at 163.com>;bhuvanendra.kumarn <bhuvanendra.kumarn at amd.com>;wangyihansh <wangyihansh at outlook.com>;yanliang.mu <yanliang.mu at intel.com>;aeubanks <aeubanks at google.com>;dougpuob <dougpuob at gmail.com>;michael.hliao <michael.hliao at gmail.com>;mcrosier <mcrosier at codeaurora.org>;jun.l <jun.l at samsung.com>;diana.picus <diana.picus at linaro.org>;flo <flo at fhahn.net>;david.green <david.green at arm.com>;simon.moll <simon.moll at emea.nec.com>;ruiling.song <ruiling.song at amd.com>;caroline.concatto <caroline.concatto at arm.com>
时 间：2022-04-11 18:28:13
主 题：[PATCH] D123449 <https://reviews.llvm.org/D123449>: [AArch64][SelectionDAG] Refactor to support more scalable vector extending stores

paulwalker-arm added inline comments.




Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7780

  if (StVT.isScalableVector())

- report_fatal_error("Cannot scalarize scalable vector stores");

----------------

Thanks for the change @Allen.  Before accepting I just wanted to query this line.  What's the circumstance where it now triggers? (I tried `llvm-lit -v ../llvm-project/llvm/test/CodeGen/AArch64` without this change and nothing jumped out)  I ask because it's not immediate clear to me that the callers are happy for the scalarisation request to be ignored, hence the original error message.

CHANGES SINCE LAST ACTION

  https://reviews.llvm.org/D123449/new/

https://reviews.llvm.org/D123449


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123449/new/

https://reviews.llvm.org/D123449