[PATCH] D123449: [AArch64][SelectionDAG] Refactor to support more scalable vector extending stores
Paul Walker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 03:27:51 PDT 2022
paulwalker-arm added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:7780
if (StVT.isScalableVector())
- report_fatal_error("Cannot scalarize scalable vector stores");
----------------
Thanks for the change @Allen. Before accepting I just wanted to query this line. What's the circumstance where it now triggers? (I tried `llvm-lit -v ../llvm-project/llvm/test/CodeGen/AArch64` without this change and nothing jumped out) I ask because it's not immediate clear to me that the callers are happy for the scalarisation request to be ignored, hence the original error message.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123449/new/
https://reviews.llvm.org/D123449
More information about the llvm-commits
mailing list