[PATCH] D123516: Fix SLP score for out of order contiguous loads

Thu Apr 14 05:24:35 PDT 2022

ABataev added a comment.

In D123516#3451025 <https://reviews.llvm.org/D123516#3451025>, @alban.bridonneau wrote:

> @ABataev , I had a look at the various patches you pointed. That looks like a proper piece of work! Given how much change is going to happen, i don't think it is worth pushing the fix i am proposing today.
>
> However, I'd like to make sure my test case will get fixed, if possible. I tried your original patch (rebased last July) on the unit test and that failed. Do you think you could incorporate this unit test in your work?

Sure, +1 here. You can add the test separately with the CHECKs for currently emitted code and a FIXME message how it is expected to be.
The more tests we have, the better. Iy would be much easier for me to tune the patch.

> I have reduced the unit test further, there is no more loop control, and the gep indices have been cleaned up. The CHECK lines are also more targeted to say we are looking for a vectorization of 4 (it currently does 2). We can actually see much better now which is the root cause of my issue. The LHS operands of the fmul are what's deciding which is the first group of loads beeing evaluated, and that group does not have 4 contiguous loads.

I'll check it, thanks. Follow suggestions from @vporpo to commit the test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123516/new/

https://reviews.llvm.org/D123516