[PATCH] D122268: Add PointerType analysis for DirectX backend

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/PointerTypeAnalysis.h:31
+/// migrated to a custom Type if PointerType loses typed support.
+namespace PointerTypeAnalysis {
+
----------------
nhaehnle wrote:
> Should the namespace be DxilPointerTypeAnalysis since it's target-specific? Also, given that a namespace is used, should the using declaration above be part of the namespace? I don't feel particularly strongly on either point.
I put `TypedPointerType` in the `dxil` namespace, maybe that makes sense here too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122268/new/

https://reviews.llvm.org/D122268