[PATCH] D122268: Add PointerType analysis for DirectX backend

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/PointerTypeAnalysis.cpp:47
+      else if (PointeeTy != NewPointeeTy)
+        PointeeTy = Type::getInt8Ty(V->getContext());
+    }
----------------
nhaehnle wrote:
> I imagine this should be a TypedPointerType?
It is meant to be the pointee type. In cases where the analysis detects more than one element type it falls back to an `i8*`, and relies on bitcasts being inserted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122268/new/

https://reviews.llvm.org/D122268