[PATCH] D122106: [BOLT] Fix dynamic relocation offset for constant islands
    Vladislav Khmelevsky via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Apr 13 16:35:24 PDT 2022
    
    
  
yota9 added a comment.
@rafaelauler As I understand we will need to keep dynamic relocations in binary function/data like we do it for static relocation and emit labels in the right places.  Let's discuss it in discord in the nearest time if you have any suggestion. I don't really like the binary function part of the code too (initially I've made the review NFC). As for this review I suggest to separate the container type refactoring and to think about the dynamic relocations emission separately, what do you think?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122106/new/
https://reviews.llvm.org/D122106
    
    
More information about the llvm-commits
mailing list