[PATCH] D122106: [BOLT] Fix dynamic relocation offset for constant islands
Rafael Auler via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 13 14:55:22 PDT 2022
rafauler added a comment.
I've been discussing this diff with the team and in general people are not only concerned about the memory/time regression, but it feels like a hacky approach. We need proper support for dynamic relocations in BOLT, and in doing so, the code should become easier to understand and maintain. What's your take? Do you think that you could design things in a way to make these concerns go away? If you would like to, we can set up a time to discuss my suggestion over VC or text chat, if it's not clear.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122106/new/
https://reviews.llvm.org/D122106
More information about the llvm-commits
mailing list