[PATCH] D123323: Adds diagnostics for missing opportunities of indirect call promotion.

[Hyoun Kyu Cho via Phabricator via llvm-commits]

netforce added a comment.

Added a test. PTAL.



================
Comment at: llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:373
+    }
+    uint64_t RemainingCount = TotalCount;
+    for (uint32_t I = 0; I < NumCandidates; I++) {
----------------
xur wrote:
> How about move this ilne to line 412 to ICallPromotionAnalysis? I think that's a better place for this.
> 
Could you clarify this comment in a little more detail? Do you suggest changing the interface of  ICallAnalysis.getPromotionCandidatesForInstruction() so that it could also exposed RemainingCount next to TotalCount? I don't see how it could be moved to line 412.


================
Comment at: llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:380
+      ORE.emit([&]() {
+        OptimizationRemarkMissed R(DEBUG_TYPE, "NotEnoughCoverage", CB);
+        if (NumCandidates == MaxNumPromotions) {
----------------
xur wrote:
> How about NotMeetPercentThreshold. It's better to use a same terms for the whole message.
> 
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123323/new/

https://reviews.llvm.org/D123323