[PATCH] D123323: Adds diagnostics for missing opportunities of indirect call promotion.

[Hyoun Kyu Cho via Phabricator via llvm-commits]

netforce updated this revision to Diff 422609.
netforce added a comment.
Herald added a subscriber: wenlei.

Added a test and fixed some minor issues that I found while adding the test.

ICallPromotionAnalysis::getPromotionCandidatesForInstruction used to return only MaxNumPromotions targets even when there are more number of targets. So, added MaxNumTargets to set that number separately.

The desired coverage should be (100 - ICPMissingPercentThreshold) and not ICPMissingPercentThreshold.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123323/new/

https://reviews.llvm.org/D123323

Files:
  llvm/lib/Analysis/IndirectCallPromotionAnalysis.cpp
  llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
  llvm/test/Transforms/PGOProfile/icp_missed_msg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123323.422609.patch
Type: text/x-patch
Size: 8345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220413/4f06a2ef/attachment.bin>