[PATCH] D123591: [LLD][COFF] Add support for /noimplib

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 07:42:42 PDT 2022


thieta added a comment.

In D123591#3447838 <https://reviews.llvm.org/D123591#3447838>, @mstorsjo wrote:

> In D123591#3447830 <https://reviews.llvm.org/D123591#3447830>, @thieta wrote:
>
>> I'll take another pass after lunch - will verify what link does as well. If there is no change in functionality- can that be submitted as a NFC or should I open another review.
>
> Yeah if it's just a NFC change getting rid of the warning, I'd say go ahead and push without review here.

I checked and they behave the same. I pushed a NFC for the warning here https://github.com/llvm/llvm-project/commit/837d16fb4c1cb00c5d0c72a0dff543f0bd5ff770


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123591/new/

https://reviews.llvm.org/D123591



More information about the llvm-commits mailing list