[PATCH] D122968: [AArch64][SelectionDAG] Add target-specific implementation of srem

[chenglin.bi via Phabricator via llvm-commits]

bcl5980 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:4314
+SDValue DAGCombiner::visitSDIVLike(SDValue N0, SDValue N1, SDNode *N,
+                                   bool &BuildRem) {
   SDLoc DL(N);
----------------
efriedma wrote:
> I'm not sure I like the modified API for visitSDIVLike?  It's sort of weird that the return value is either the quotient or the remainder, depending on the value of BuildRem.  And that BuildRem is both an input and an output.
Yeah, this part is ugly. I will refactor this part today


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122968/new/

https://reviews.llvm.org/D122968