[PATCH] D122968: [AArch64][SelectionDAG] Add target-specific implementation of srem

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 04:43:32 PDT 2022


bcl5980 added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/srem-lkk.ll:171
+}
+
----------------
efriedma wrote:
> Maybe we also want some tests for i16?
> 
> Please post a separate patch to add the new tests, so it's easier to compare the impact.  And actually, while you're at it, maybe stick all the power-of-two tests in a separate file with a better name.
separate patch: D123671
@efriedma  Can you help to review?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122968/new/

https://reviews.llvm.org/D122968



More information about the llvm-commits mailing list