[PATCH] D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy.

[Christudasan Devadasan via Phabricator via llvm-commits]

cdevadas added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.h:497
+private:
+  Register VGPRForAGPRCopy = AMDGPU::NoRegister;
+
----------------
No need for the initializer. It takes `NoRegister` by default.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:702
+    auto reservedVGPR =
+        const_cast<SIMachineFunctionInfo *>(MFI)->reserveVGPRForAGPRCopy(
+            MaxNumVGPRs - 1);
----------------
I don't think it's the right place to reserve the VGPR by changing the constness of MFI.
May be finalizeLowering?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123651/new/

https://reviews.llvm.org/D123651