[PATCH] D123491: [AArch64] Add missing HasNEON predicate in scalar FABD patterns

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 14:01:48 PDT 2022


arichardson marked 3 inline comments as done.
arichardson added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/fabd-no-neon.ll:12
+
+define half @fabd16(half %f1, half %f2) local_unnamed_addr nounwind {
+; NEON-ENABLED-LABEL: fabd16:
----------------
dmgreen wrote:
> Can remove local_unnamed_addr and maybe nounwind? (Although that sometimes adds noise to the assembly)
Yeah I added nounwind to avoid the .cfi instructions, but it seems like they aren't generated even without the attribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123491/new/

https://reviews.llvm.org/D123491



More information about the llvm-commits mailing list