[PATCH] D123491: [AArch64] Add missing HasNEON predicate in scalar FABD patterns

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Sounds good to me. I have some minor comments about cleaning up the tests a little, but otherwise LGTM.



================
Comment at: llvm/test/CodeGen/AArch64/fabd-no-neon.ll:4
+; an assertion in verifyInstructionPredicates() while emitting the output.
+; RUN: llc -mtriple=aarch64 -mattr=+v8.2a,+fullfp16,+neon < %s | FileCheck %s --check-prefix NEON-ENABLED
+; RUN: llc -mtriple=aarch64 -mattr=+v8.2a,+fullfp16,-neon < %s | FileCheck %s --check-prefix NEON-DISABLED
----------------
Does this need +v8.2a?


================
Comment at: llvm/test/CodeGen/AArch64/fabd-no-neon.ll:10
+
+target triple = "aarch64-unknown-unknown-elf"
+
----------------
This can be removed, so long as the mtriple is specified in the command line.


================
Comment at: llvm/test/CodeGen/AArch64/fabd-no-neon.ll:12
+
+define half @fabd16(half %f1, half %f2) local_unnamed_addr nounwind {
+; NEON-ENABLED-LABEL: fabd16:
----------------
Can remove local_unnamed_addr and maybe nounwind? (Although that sometimes adds noise to the assembly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123491/new/

https://reviews.llvm.org/D123491