[PATCH] D118214: [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.
Ahmed Bougacha via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 12 10:41:57 PDT 2022
ab added a comment.
D'oh, this fell through the cracks, sorry folks! I committed the fix I had in mind (cfa4fe7c5187 <https://reviews.llvm.org/rGcfa4fe7c51870fe6b480d541938f556cf0736fa2>). Long story short: this change exposed an old bug in the LOH pass: it wasn't honoring regmasks in bundled MIs, but since we used to split the bundle and emit the attached call separately, the (unbundled) latter was still visible to the pass. That's not true as of this change. I think for the sort of code that uses bundles on aarch64 it's usually selectors that get corrupted in a later msgSend, and that ends up exploding in dyld the way we're seeing in both cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118214/new/
https://reviews.llvm.org/D118214
More information about the llvm-commits
mailing list