[PATCH] D118214: [ObjCARC] Require the function argument in the clang.arc.attachedcall bundle.
Mike Hommey via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 23:47:17 PDT 2022
glandium added a comment.
FWIW, We're seeing Firefox crashes on aarch64 macos that have been bisected to this change as well. Top frames look like:
Thread 94 VideoCapture (crashed)
0 libsystem_platform.dylib!_platform_strlen + 0x4
x0 = 0x00000000018963bf x1 = 0x00000000018963b0
x2 = 0x0000000000000001 x3 = 0x000000005650a7e3
x4 = 0x0000000000000000 x5 = 0x0000000000000000
x6 = 0x0000000000000065 x7 = 0x0000000000000000
x8 = 0x00000001e2a220c8 x9 = 0x00000000593e20c8
x10 = 0x00000001f405db98 x11 = 0x0000000189494000
x12 = 0x0000000217e4c000 x13 = 0x0000000100000000
x14 = 0x000000000000000c x15 = 0x000000018963bca1
x16 = 0x00000001897c2fa0 x17 = 0x00000001ef3c5dc0
x18 = 0x0000000000000000 x19 = 0x00000000018963bf
x20 = 0x00000001e2a220c8 x21 = 0x0000000000000001
x22 = 0x00000000018963bf x23 = 0x00000001f3a6d898
x24 = 0x00000001dfb46c13 x25 = 0x0000000000000000
x26 = 0x00000001dfb46c42 x27 = 0x00000000ffffffff
x28 = 0x0000000000000000 fp = 0x0000000172aba2a0
lr = 0x000000018978586c sp = 0x0000000172aba280
pc = 0x00000001897c2fa4
Found by: given as instruction pointer in context
1 libdyld.dylib!objc_opt::objc_stringhash_t::getIndex(char const*) const + 0x20
sp = 0x0000000172aba2b0 pc = 0x000000018978586c
Found by: previous frame's frame pointer
2 libdyld.dylib!_dyld_get_objc_selector + 0x3c
sp = 0x0000000172aba2d0 pc = 0x00000001897857dc
Found by: previous frame's frame pointer
3 libobjc.A.dylib!__sel_registerName(char const*, bool, bool) + 0x2c
sp = 0x0000000172aba320 pc = 0x00000001896367e8
Found by: previous frame's frame pointer
4 CoreFoundation!___forwarding___ + 0x54c
sp = 0x0000000172aba490 pc = 0x0000000189858130
Found by: previous frame's frame pointer
5 CoreFoundation!__forwarding_prep_0___ + 0x5c
sp = 0x0000000172aba570 pc = 0x0000000189857b30
Found by: previous frame's frame pointer
6 XUL!-[DeviceInfoIosObjC configureObservers] [device_info_objc.mm:6475d6ae523de8e02c1e5c20ddaab4593cc16495 : 131 + 0x14]
sp = 0x0000000172aba650 pc = 0x00000001057860a0
Found by: previous frame's frame pointer
7 XUL!webrtc::videocapturemodule::DeviceInfoIos::Init() [device_info.mm:6475d6ae523de8e02c1e5c20ddaab4593cc16495 : 42 + 0x8]
x19 = 0x000000014abdfdf0 x20 = 0x000000014a4457c0
x21 = 0xdb95bce6c9860006 x22 = 0x000000010ab71c30
x23 = 0x000000014a9e4d40 x24 = 0x00000000000041b7
x25 = 0x00000001057856ac x26 = 0x0000000172aba680
x27 = 0x000000014a9e4d40 x28 = 0x000000014a9e4d40
fp = 0x0000000172abaa70 sp = 0x0000000172aba690
pc = 0x0000000105784a08
Found by: call frame info
8 XUL!webrtc::videocapturemodule::VideoCaptureImpl::CreateDeviceInfo() [device_info.mm:6475d6ae523de8e02c1e5c20ddaab4593cc16495 : 35 + 0x44]
x19 = 0x000000014abdfdf0 x20 = 0x000000014a4457c0
x21 = 0x000000014abdfe80 x22 = 0x000000010a41723c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118214/new/
https://reviews.llvm.org/D118214
More information about the llvm-commits
mailing list