[PATCH] D123622: [AMDGPU] Allow sinking defs with multiple uses in PreRARemterialize scheduling stage

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D123622#3446149 <https://reviews.llvm.org/D123622#3446149>, @vangthao wrote:

> In D123622#3446136 <https://reviews.llvm.org/D123622#3446136>, @rampitec wrote:
>
>> Is there a real usecase? I do not like scheduler going that way.
>
> This fixes the regression in SWDEV-316487. I agree that this is making the scheduler too complex. We really need to a way to calculate register pressure before hoisting trivially rematerializable defs in MachineLICM or make this its own pass.

Is that still a problem? Wasn't it fixed by the first commit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123622/new/

https://reviews.llvm.org/D123622