[PATCH] D123622: [AMDGPU] Allow sinking defs with multiple uses in PreRARemterialize scheduling stage

Vang Thao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 12 10:16:58 PDT 2022


vangthao added a comment.

In D123622#3446136 <https://reviews.llvm.org/D123622#3446136>, @rampitec wrote:

> Is there a real usecase? I do not like scheduler going that way.

This fixes the regression in SWDEV-316487. I agree that this is making the scheduler too complex. We really need to a way to calculate register pressure before hoisting trivially rematerializable defs in MachineLICM or make this its own pass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123622/new/

https://reviews.llvm.org/D123622



More information about the llvm-commits mailing list