[PATCH] D123181: [RISCV] Refactoring the type promotion process of instructions fsl/fsr
Jessica Clarke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 11 13:27:29 PDT 2022
jrtc27 added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:6589
+ // Deal with the Instruction Operands
+ SmallVector<SDValue, 8> NewOp;
+ // Walk through the operand list.
----------------
craig.topper wrote:
> 8 seems high. Are we ever using more than 3?
Name should be plural
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123181/new/
https://reviews.llvm.org/D123181
More information about the llvm-commits
mailing list