[PATCH] D123531: [GlobalsModRef][FIX] Ensure we honor synchronizing effects of intrinsics

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 11 12:05:17 PDT 2022


jdoerfert added a comment.

In D123531#3443483 <https://reviews.llvm.org/D123531#3443483>, @efriedma wrote:

> My understanding is that the assumption the code is trying to make is that intrinsics are special because they can't call other code in the current module.
>
> In practice, this is wrong for two reasons:
>
> 1. Some intrinsics imply synchronization.
> 2. Some intrinsics can call arbitrary code.

Right. I only checked 1. I also need to check `nocallback` for 2. Will update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123531/new/

https://reviews.llvm.org/D123531



More information about the llvm-commits mailing list