[PATCH] D123531: [GlobalsModRef][FIX] Ensure we honor synchronizing effects of intrinsics

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

My understanding is that the assumption the code is trying to make is that intrinsics are special because they can't call other code in the current module.

In practice, this is wrong for two reasons:

1. Some intrinsics imply synchronization.
2. Some intrinsics can call arbitrary code.

So I don't think hasNoSync() is sufficient...

I'd appreciate a better comment about the invariants involved here.

(Looking more closely, I don't think this really overlaps with D115302 <https://reviews.llvm.org/D115302>.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123531/new/

https://reviews.llvm.org/D123531