[PATCH] D123483: [llvm-pdbutil] Fix broken '-modi' option after change D122226.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 10 23:59:25 PDT 2022


CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: rnk, aganea, dblaikie, probinson, zequanwu.
CarlosAlbertoEnciso added a project: LLVM.
Herald added a subscriber: hiraditya.
Herald added a project: All.
CarlosAlbertoEnciso requested review of this revision.
Herald added a subscriber: llvm-commits.

The change described by:

https://reviews.llvm.org/D122226

Moved some llvm-pdbutil functionality to the debug PDB library.

This patch addresses a broken '-modi' argument handling, which causes an assertion if its value is other than '0' or '1'.
In addition, moves the assertion for that argument from the PDB library into the llvm-pdbutil driver.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123483

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/InputFile.h
  llvm/include/llvm/DebugInfo/PDB/Native/LinePrinter.h
  llvm/lib/DebugInfo/PDB/Native/InputFile.cpp
  llvm/test/tools/llvm-pdbutil/modi.test
  llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123483.421838.patch
Type: text/x-patch
Size: 3837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220411/9ba00f69/attachment.bin>


More information about the llvm-commits mailing list