[PATCH] D123390: [demangler][NFC] OperatorInfo table unit test

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 10 13:29:00 PDT 2022


dblaikie added a comment.

Would a more direct fix be, rather than using the C++ library call_once feature, instead using the equivalent language feature:

  static int unused = [&]() {
    /* whatever you want to do once */
  }, 0;

Though if we can move the logic out of the production codepath and into a test entirely, that does seem better anyway - so this is probably the right direction. (I probably won't be the one to approve this - maybe @JDevlieghere has a bit more context in this chain of patches)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123390/new/

https://reviews.llvm.org/D123390



More information about the llvm-commits mailing list